[FrameworkBundle] Lower uppercase must
#20176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Aug 30, 2024
| @@ -3268,7 +3268,7 @@ settings from the base pool as defaults. | |||
|
|
|||
| .. note:: | |||
|
|
|||
| Your service MUST implement the ``Psr\Cache\CacheItemPoolInterface`` interface. | |||
| Your service **must** implement the ``Psr\Cache\CacheItemPoolInterface`` interface. | |||
There was a problem hiding this comment.
Suggested change
| Your service **must** implement the ``Psr\Cache\CacheItemPoolInterface`` interface. | |
| Your service needs to implement the ``Psr\Cache\CacheItemPoolInterface`` interface. |
? not sure its enough
|
Thanks Alex. This indeed look too aggressive. While merging we went a bit further and changed it as recommended by Oskar. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just came across this one and it felt out of place. We tend to avoid "must". Even if I agree it is required in this situation, let's use bold instead of uppercase, feels less aggressive 🙂